feat(lazer): add history api client for symbols #3035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Riateche
changed the title
| /// immediately from the returned receiver. | ||
| /// You should continuously poll the receiver to receive updates. | ||
| /// | ||
| /// Panics if the buffer capacity is 0. |
There was a problem hiding this comment.
since we are returning a Result let's return Err instead of panicing.
| println!("feeds len: {}", feeds.symbols().len()); | ||
| println!("feed 1: {:?}", feeds.symbols().get(&PriceFeedId(1))); | ||
| sleep(Duration::from_secs(15)).await; | ||
| } |
There was a problem hiding this comment.
would be nice to have an example for stream too.
keyvankhademi
approved these changes
Sep 9, 2025
Riateche
force-pushed
the
add-lazer-api-client
branch
from
c7cc61e to
75c8ee1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I wasn't sure what would be the most convenient API for fetching symbol updates, so I added a few different methods:
all_symbols_metadata- fetches only once.all_symbols_metadata_handle- returns an ArcSwap that will be continuously updated in background. Convenient for migrating old code, but there is no way to get a notification when something changed.all_symbols_metadata_fault_tolerant_handle- same as above, but returns an empty value if the initial fetch failed. Useful for relayer: while it needs symbols for some things, it can still work without them.all_symbols_metadata_stream- the most flexible option: get a receiver that receives new symbols.There is also a caching feature: to avoid hard dependency on history service, we can store last known symbols locally and fetch them on startup.
Rationale
To remove
symbols.tomland use symbols for the state-aware history service.How has this been tested?
Tested in tilt.