Skip to content

Conversation

tejasbadadare
Copy link
Contributor

Summary

Swallow exceptions in SearcherClient.onBundleResult. Not all errors are propagated via the err callback, some are simply thrown. These uncaught exceptions will crash the app, so we swallow and log them instead.

How has this been tested?

  • Current tests cover my changes
  • Added new tests
  • Manually tested the code
    • Manually tested that early errors such as bad auth no longer crash the app

@tejasbadadare tejasbadadare requested a review from a team as a code owner September 9, 2025 23:19
Copy link

vercel bot commented Sep 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

7 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
api-reference Skipped Skipped Sep 10, 2025 2:42pm
component-library Skipped Skipped Sep 10, 2025 2:42pm
developer-hub Skipped Skipped Sep 10, 2025 2:42pm
entropy-explorer Skipped Skipped Sep 10, 2025 2:42pm
insights Skipped Skipped Sep 10, 2025 2:42pm
proposals Skipped Skipped Sep 10, 2025 2:42pm
staking Skipped Skipped Sep 10, 2025 2:42pm

@vercel vercel bot temporarily deployed to Preview – entropy-explorer September 10, 2025 14:42 Inactive
@vercel vercel bot temporarily deployed to Preview – staking September 10, 2025 14:42 Inactive
@vercel vercel bot temporarily deployed to Preview – component-library September 10, 2025 14:42 Inactive
@vercel vercel bot temporarily deployed to Preview – api-reference September 10, 2025 14:42 Inactive
@vercel vercel bot temporarily deployed to Preview – insights September 10, 2025 14:42 Inactive
@vercel vercel bot temporarily deployed to Preview – proposals September 10, 2025 14:42 Inactive
@vercel vercel bot temporarily deployed to Preview – developer-hub September 10, 2025 14:42 Inactive
@tejasbadadare tejasbadadare merged commit c1c20a9 into main Sep 11, 2025
10 of 11 checks passed
@tejasbadadare tejasbadadare deleted the tb/solana-pusher/catch-jito-onBundleResult-excs branch September 11, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants