p2w: Monitor and realloc() + rent adjuist on cfg account size change #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
reviewed
Sep 26, 2022
| // Realloc if mismatched | ||
| if old_size != new_size { | ||
| accs.config.info().realloc(new_size, false)?; | ||
| } |
There was a problem hiding this comment.
Maybe realloc the account and then set accs.config.1 = data, just to be safe? It looks like realloc doesn't change any bytes of the account, but you don't need to depend on that property if you reorder these two lines.
There was a problem hiding this comment.
That makes sense, will do
drozdziak1
deleted the
drozdziak1/p2w-set-config-dynamic-rent-adjustment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem I observed together with Ali in devnet. Options in borsh result in byte count changes which means the underlying account size for contract state must grow/shrink together with the serialized byte length. This change implements such a scheme.