Skip to content

fix: skeleton fill #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 29, 2025
Merged

fix: skeleton fill #3089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
360f33e
fix: skeleton fill
alexcambose Sep 26, 2025
786c543
fix: formatting
alexcambose Sep 26, 2025
bbc4c4e
fix
alexcambose Sep 26, 2025
9faafbd
fix
alexcambose Sep 29, 2025
bf22b39
fix
alexcambose Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/component-library/src/Skeleton/index.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@
}
}

.fullSkeleton {
display: inline-block;
}

.skeleton {
border-radius: theme.border-radius("lg");

&[data-fill] {
width: 100%;
}

.skeletonInner {
display: inline flow-root;
width: calc(theme.spacing(1) * var(--skeleton-width));
Expand Down
7 changes: 6 additions & 1 deletion packages/component-library/src/Skeleton/index.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,14 @@ const meta = {
export default meta;

export const Skeleton = {
render: (args) => (
<div style={{ width: "100vw", display: "flex", justifyContent: "center" }}>
<SkeletonComponent {...args} />
</div>
),
args: {
label: "Loading",
width: 20,
fill: false,
width: 20,
},
} satisfies StoryObj<typeof SkeletonComponent>;
31 changes: 17 additions & 14 deletions packages/component-library/src/Skeleton/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,25 @@ type Props = Omit<ComponentProps<"span">, "children"> & {
fill?: boolean | undefined;
};

export const Skeleton = ({ className, label, width, fill, ...props }: Props) =>
fill ? (
<span className={clsx(styles.fullSkeleton, className)} {...props}>
export const Skeleton = ({
className,
label,
width,
fill,
...props
}: Props) => (
<span
data-fill-width={width === undefined ? "" : undefined}
{...(width &&
!fill && { style: { "--skeleton-width": width } as CSSProperties })}
data-fill={fill ? "" : undefined}
className={clsx(styles.skeleton, className)}
>
<span className={clsx(styles.skeletonInner, className)} {...props}>
<Label>{label ?? "Loading"}</Label>
</span>
) : (
<span
data-fill-width={width === undefined ? "" : undefined}
{...(width && { style: { "--skeleton-width": width } as CSSProperties })}
className={clsx(styles.skeleton, { [className ?? ""]: fill })}
>
<span className={clsx(styles.skeletonInner, className)} {...props}>
<Label>{label ?? "Loading"}</Label>
</span>
</span>
);
</span>
);

const Label = ({ children }: { children: string | undefined }) => (
<span className={styles.skeletonLabel}>{children ?? "Loading"}</span>
Expand Down
Loading