Skip to content

refactor(component-library): set default page sizes #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
Merged

refactor(component-library): set default page sizes #3094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/insights/src/components/PriceComponentsCard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,6 @@ export const PriceComponentsCardContents = <
onPageChange={props.onPageChange}
pageSize={props.pageSize}
onPageSizeChange={props.onPageSizeChange}
pageSizeOptions={[10, 20, 30, 40, 50]}
mkPageLink={props.mkPageLink}
/>
),
Expand Down
1 change: 0 additions & 1 deletion apps/insights/src/components/PriceFeeds/price-feeds-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,6 @@ const PriceFeedsCardContents = ({ id, ...props }: PriceFeedsCardContents) => (
onPageChange={props.onPageChange}
pageSize={props.pageSize}
onPageSizeChange={props.onPageSizeChange}
pageSizeOptions={[10, 20, 30, 40, 50]}
mkPageLink={props.mkPageLink}
/>
),
Expand Down
1 change: 0 additions & 1 deletion apps/insights/src/components/Publishers/publishers-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,6 @@ const PublishersCardContents = ({
onPageChange={props.onPageChange}
pageSize={props.pageSize}
onPageSizeChange={props.onPageSizeChange}
pageSizeOptions={[10, 20, 30, 40, 50]}
mkPageLink={props.mkPageLink}
/>
),
Expand Down
6 changes: 4 additions & 2 deletions packages/component-library/src/Paginator/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,21 @@ type Props = {
onPageChange: (newPage: number) => void;
isPageTransitioning?: boolean | undefined;
pageSize: number;
pageSizeOptions: number[];
pageSizeOptions?: number[];
onPageSizeChange: (newPageSize: number) => void;
isPageSizeTransitioning?: boolean | undefined;
mkPageLink?: ((page: number) => string) | undefined;
className?: string | undefined;
};

const DEFAULT_PAGE_SIZE_OPTIONS = [10, 20, 30, 40, 50];

export const Paginator = ({
numPages,
currentPage,
isPageTransitioning,
pageSize,
pageSizeOptions,
pageSizeOptions = DEFAULT_PAGE_SIZE_OPTIONS,
onPageChange,
onPageSizeChange,
isPageSizeTransitioning,
Expand Down
Loading