feat(hip-3-pusher): AWS client config, backup write support, minor fixes #3100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
merolish
changed the title
tejasbadadare
approved these changes
Oct 3, 2025
Comment on lines
+37
to
+39
| except Exception as e: | ||
| logger.exception("Failed to load public key from KMS; it might be incorrectly configured; error: {}", repr(e)) | ||
| exit() |
There was a problem hiding this comment.
Invoking exit() isn't ideal (often times this doesn't work the way you expect, esp in threaded/async workloads.) Lets just rethrow a chained exception. It should crash the program as expected. Something like
except Exception as e:
logger.exception(...)
throw Exception("Failed to load public key from KMS") from e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rationale
How has this been tested?