Skip to content

[xc-admin] Add wormhole logic to the crank-executor #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 17, 2023
Merged

[xc-admin] Add wormhole logic to the crank-executor #504

merged 5 commits into from
Jan 17, 2023

Conversation

guibescos
Copy link
Contributor

@guibescos guibescos commented Jan 17, 2023 •
edited
Loading

The crank that executes the proposals will be aware of wormhole transactions and pay the transfer fee

@vercel
Copy link

vercel bot commented Jan 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
xc-admin-frontend ⬜️ Ignored (Inspect) Jan 17, 2023 at 9:43PM (UTC)

@guibescos guibescos changed the title Add wormhole and fix some bugs Add wormhole logic to the crank-executor Jan 17, 2023
@guibescos guibescos changed the title Add wormhole logic to the crank-executor [xc-admin] Add wormhole logic to the crank-executor Jan 17, 2023
jayantk
jayantk approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

this question is somewhat unrelated but it would be nice to have some testing infrastructure for this code. Would be great to have tests to validate that this fee payment worked, etc. I realize that's not trivial but it's worth thinking about how to set it up.

@guibescos
Copy link
Contributor Author

guibescos commented Jan 17, 2023 •
edited
Loading

LGTM

this question is somewhat unrelated but it would be nice to have some testing infrastructure for this code. Would be great to have tests to validate that this fee payment worked, etc. I realize that's not trivial but it's worth thinking about how to set it up.

I've been testing it on tilt, but there are a lot of missing pieces : pythnet, etc... Might need to spend some time setting it up.

@guibescos guibescos closed this Jan 17, 2023
@guibescos guibescos reopened this Jan 17, 2023
@guibescos guibescos merged commit 1940a0b into main Jan 17, 2023
@guibescos guibescos deleted the xc-admin/add-wormhole-to-executor-crank branch January 17, 2023 23:19
@ali-behjati
Copy link
Collaborator

@guibescos I think its good to spend some time and set it up in tilt, both the backend and the frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantk jayantk jayantk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guibescos @ali-behjati @jayantk