[eth] Add token swap example application #518
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
|
||
| ``` | ||
| forge install foundry-rs/forge-std@2c7cbfc6fbede6d7c9e6b17afe997e3fdfe22fef --no-git --no-commit | ||
| forge install pyth-network/pyth-sdk-solidity@v1.0.1 --no-git --no-commit |
There was a problem hiding this comment.
for future: we can update this sdk to the new version. the only change will be the getUpdateFee method.
| @@ -0,0 +1,272 @@ | |||
| [ | |||
There was a problem hiding this comment.
For future: maybe move abis to an abi directory?
| } | ||
| } | ||
|
|
||
| // TODO: we should probably move something like this into the solidity sdk |
There was a problem hiding this comment.
Yeah i had the same impression for this too. But If it is an example we want to share with people, can we add this as an issue and remove it from here?
|
|
||
| if (isBuy) { | ||
| // (Round up) | ||
| quoteSize += 1; |
There was a problem hiding this comment.
This is only true if the remainder of size * basePrice % quotePrice is positive, right? I guess its fine.
| // (Round up) | ||
| quoteSize += 1; | ||
|
|
||
| quoteToken.transferFrom(msg.sender, address(this), quoteSize); |
There was a problem hiding this comment.
Let's add that the transaction reverts if there is not enough fund in the users wallet or the contract.
| } | ||
|
|
||
| function testSwap() public { | ||
| setupTokens(10e18, 10e18, 10e18, 10e18); |
There was a problem hiding this comment.
maybe move this to setUp too?
ali-behjati
changed the title
This is an example oracle AMM application using Pyth prices. I'll give you the context for why we need this on slack.
(I based this on @ali-bahjati 's ETH transfer example)
The frontend associated with this app is very janky at the moment. It works, but it needs some love. I'll come back to that in the next PR.
