Skip to content

[xc-admin] add proposals page #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 10, 2023
Merged

[xc-admin] add proposals page #570

merged 7 commits into from
Feb 10, 2023

Conversation

cctdaniel
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Feb 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
xc-admin-frontend ✅ Ready (Inspect) Visit Preview ✅ 4 resolved Feb 10, 2023 at 6:13AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
example-oracle-amm ⬜️ Ignored (Inspect) 💬 Add your feedback Feb 10, 2023 at 6:13AM (UTC)

guibescos
guibescos approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@guibescos guibescos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking really good, just make sure that unrecognized instructions also show. It can be very dangerous otherwise (proposal appears empty but has "hidden" bad instructions).

@cctdaniel cctdaniel merged commit a478d9f into main Feb 10, 2023
@cctdaniel cctdaniel deleted the xc-admin-proposals branch February 10, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guibescos guibescos guibescos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cctdaniel @guibescos