[Xc admin] frontend to use server #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
guibescos
commented
May 22, 2023
| isPermission | ||
| ? pythProgramClient.methods | ||
|
|
||
| for (const priceAccount of priceAccounts) { |
There was a problem hiding this comment.
Had to rewrite this logic to await for the instructions, otherwise there's a race condition.
cctdaniel
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make xc-admin-frontend send the proposal instructions to the proposer server, that will submit them to the multisig.
You can test it locally by setting
NEXT_PUBLIC_PROPOSER_SERVER_URLto the right value.I tried to keep this one small, might be able to cleanup further once it gets approved and we make sure it works.