Skip to content

fix(price_feeds/starknet): fix deploy script and add readme #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2024
Merged

fix(price_feeds/starknet): fix deploy script and add readme #17

merged 2 commits into from
Jun 27, 2024

Conversation

Riateche
Copy link
Contributor

  • Renamed the deploy script to deploy.sh (in a separate commit for easier review).
  • Removed the testing code that required Rust from the deploy script. We have the TS client that can be used to test the contract.
  • Changed the deploy script to allow redirecting output to an env file.
  • Added readme with deploy instructions.

Related: pyth-network/pyth-crosschain#1736

@Riateche Riateche merged commit 8da293e into main Jun 27, 2024
@Riateche Riateche deleted the fix-deploy-script branch June 27, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ali-behjati ali-behjati ali-behjati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Riateche @ali-behjati