This repository was archived by the owner on Apr 3, 2023. It is now read-only.
Fix leading 0x in websocket logic #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantk
approved these changes
Jul 25, 2022
jayantk
reviewed
Jul 25, 2022
jayantk
approved these changes
Jul 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, when the websocket received a new price feed update it matched the data id (without leading 0x) with a mapping of ids (possibly with leading 0x) to callbacks in order to call the callbacks. So a subscription with an id with leading 0x wouldn't work.
This will remove the leading 0x if exists in the beginning of processing price ids in sub/unsub calls to fix this problem.
Also bumps the version to 0.4.0.