Skip to content
This repository was archived by the owner on Apr 3, 2023. It is now read-only.

Update packages according to pyth-sdk-solidity v1 interface #43

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Update packages according to pyth-sdk-solidity v1 interface #43

merged 3 commits into from
Oct 3, 2022

Conversation

ali-behjati
Copy link
Contributor

I didn't bump versions to 1 because js sdk is not updated yet. Will do that next week.

@ali-behjati ali-behjati requested a review from jayantk September 30, 2022 17:43
jayantk
jayantk approved these changes Oct 2, 2022
View reviewed changes
Copy link
Contributor

@jayantk jayantk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't actually know how fee paying like this works in solidity, but i'm going to approve this to unblock you. It would be good to make a full working example to validate that all this code works as intended.

@ali-behjati ali-behjati merged commit e0a4fe0 into main Oct 3, 2022
@ali-behjati ali-behjati deleted the abehjati/update-interface branch October 3, 2022 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jayantk jayantk jayantk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ali-behjati @jayantk