This repository was archived by the owner on Apr 3, 2023. It is now read-only.
Update packages to handle fee #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is decommissioned
jayantk
approved these changes
Oct 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our pyth-evm-js example and price pusher did not handle fee. This PR adds this behaviour and updates the Readme to explain it.
Other small changes:
In a future PR we can add
getUpdateFeepart of the sdk or return it when the user requests forgetPriceUpdateData. However, I didn't do it in this PR because of the syntax variation between web3/ethers. An ideal solution would implement two methodsgetUpdateFeeWeb3getUpdateFeeEthersthat does dynamic import and has those two as optional dependency.p.s: Aptos design (like solana) does not require specifying exact amount as we have methods with funder.