This repository was archived by the owner on Apr 3, 2023. It is now read-only.
[evm-price-pusher] Make web3 connections more reslient #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also upgrade web3 packages and add skipLibCheck
jayantk
approved these changes
Nov 16, 2022
ali-behjati
changed the title
jayantk
approved these changes
Dec 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the pusher web3 connection gets dropped then uppon pushing the price it will crash with that error. This PR (1) configures the connection options to be more resilient (reconnect, ...) (2) handles this error explicitly on pushing prices.
This PR will also upgrade web3 packages and adds skipLibCheck to tsconfig.
Update: Added PythContractFactory as suggested. Also changed errors to throw and crash when the error is not handled explicitly. Crashing on unknown behaviors is better than skipping it, because (1) we'll get notified and can investigate (2) a restart might solve the problem.