-
Notifications
You must be signed in to change notification settings - Fork 7
feat(reliability) Add /live
and /ready
probes
#90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds health check endpoints (/live
and /ready
) to improve observability and reliability of the Pyth Observer service. The implementation includes a dedicated health server and integrates it with the main observer lifecycle.
- Adds a new health server module with liveness and readiness probe endpoints
- Integrates health server startup with the main observer process
- Implements observer state tracking to properly report readiness status
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.
File | Description |
---|---|
pyth_observer/health_server.py | New module implementing HTTP health check endpoints |
pyth_observer/cli.py | Updated to start health server alongside observer |
pyth_observer/init.py | Added health state tracking and error handling |
pyproject.toml | Added cffi dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
build-backend = "poetry.core.masonry.api" | ||
|
||
[tool.poetry.requires-plugins] | ||
poetry-plugin-export = ">=1.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline
No description provided.