Skip to content

Conversation

bplatak
Copy link
Contributor

@bplatak bplatak commented Oct 2, 2025

No description provided.

@bplatak bplatak requested a review from Copilot October 2, 2025 12:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds health check endpoints (/live and /ready) to improve observability and reliability of the Pyth Observer service. The implementation includes a dedicated health server and integrates it with the main observer lifecycle.

  • Adds a new health server module with liveness and readiness probe endpoints
  • Integrates health server startup with the main observer process
  • Implements observer state tracking to properly report readiness status

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.

File Description
pyth_observer/health_server.py New module implementing HTTP health check endpoints
pyth_observer/cli.py Updated to start health server alongside observer
pyth_observer/init.py Added health state tracking and error handling
pyproject.toml Added cffi dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@bplatak bplatak requested a review from Copilot October 2, 2025 14:00
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

build-backend = "poetry.core.masonry.api"

[tool.poetry.requires-plugins]
poetry-plugin-export = ">=1.8"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

@bplatak bplatak merged commit 8ab2e0e into main Oct 2, 2025
3 checks passed
@bplatak bplatak deleted the feat/reliability/add-k8s-probes-1 branch October 2, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants