fix docs build and pin pyviz_comms=0.7.2 #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoloViews didn't have a strict pinning for it. In the new version https://github.com/holoviz/pyviz_comms/blob/v0.7.2/pyviz_comms/__init__.py#L102 was removed, while holoviews=1.11.3 seems to depend on it.
|
There is no way of testing until #169 (or alternative) is merged. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HoloViews didn't have a strict pinning for it.
In the new version https://github.com/holoviz/pyviz_comms/blob/v0.7.2/pyviz_comms/__init__.py#L102
was removed, while holoviews=1.11.3 seems to depend on it.
See https://readthedocs.org/projects/adaptive/builds/10782921/
Checklist
pre-commit run --all(first install usingpip install pre-commit)pytestpassedType of change
Check relevant option(s).