Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix amalgamation #681

Merged
merged 2 commits into from
Dec 31, 2019
Merged

Fix amalgamation #681

merged 2 commits into from
Dec 31, 2019

Conversation

akx
Copy link
Member

@akx akx commented Dec 31, 2019

He Chen and others added 2 commits December 31, 2019 11:08
@akx
fix small decimal with disabled decimal_quantization
8f9b120
@sebleblanc @akx
Hardcode "ignore" method
ffd8452 
The "ignore" method used to force the opening of the file. Some editors (emacs) create symbolic links to use as synchronization locks. Those links have an extension that matches the opened file, but the links themselves do not point to an existing file, thus causing Babel to attempt to open a file that does not exist.

This fix skips opening of a file altogether when using the method "ignore" in the mapping file.
@codecov-io
Copy link

codecov-io commented Dec 31, 2019 •
edited
Loading

Codecov Report

Merging #681 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
- Coverage   90.98%   90.97%   -0.02%     
==========================================
  Files          24       24              
  Lines        4173     4175       +2     
==========================================
+ Hits         3797     3798       +1     
- Misses        376      377       +1
Impacted Files Coverage Δ
babel/messages/extract.py 94.94% <100%> (-0.33%) ⬇️
babel/numbers.py 97.68% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30355ca...ffd8452. Read the comment docs.

@akx akx merged commit c42bc9e into python-babel:master Dec 31, 2019
@akx akx deleted the misc-fixes branch April 8, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Very small decimal with disabled decimal_quantization
3 participants
@akx @codecov-io @sebleblanc