Skip to content

session: Fix API leak pt2 #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

crobinso
Copy link
Member

@crobinso crobinso commented Feb 7, 2024

session: Fix API leak pt2

Between the time 182e0b0 was written, 138caf8 was committed
which inadvertently loosened up the api_key scraping.

@crobinso crobinso changed the title Fix api key leak2 session: Fix API leak pt2 Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41f3570) 100.00% compared to head (2960d81) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #203   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines         2192      2192           
=========================================
  Hits          2192      2192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crobinso crobinso mentioned this pull request Feb 7, 2024
Between the time 182e0b0 was written, 138caf8 was committed
which inadvertently loosened up the api_key scraping.

Go back to catching `Exception` so we try harder to scrape api_key
from error messages.

Signed-off-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Cole Robinson <crobinso@redhat.com>
@crobinso crobinso merged commit 70c6ad3 into python-bugzilla:main Feb 13, 2024
@crobinso crobinso deleted the fix-api-key-leak2 branch February 13, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant