Skip to content

Conversation

KyleKing
Copy link
Contributor

@KyleKing KyleKing commented Nov 9, 2020

I replaced with_argparser_and_unknown_args with with_argparser(parser, with_unknown_args=True) per #1011 (review)

Let me know if you want me to make any follow-up changes!

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #1012 (67c18b0) into master (d443624) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1012   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files          22       22           
  Lines        4613     4613           
=======================================
  Hits         4516     4516           
  Misses         97       97           
Impacted Files Coverage Δ
cmd2/parsing.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d443624...67c18b0. Read the comment docs.

Copy link
Member

@tleonhardt tleonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kyle, thank you for helping improve the documentation!

@tleonhardt tleonhardt merged commit d3a9a6d into python-cmd2:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants