Converted persistent history files from pickle to compressed JSON #1119
Conversation
…tion configuration/commands match developer local commands.
Codecov Report
@@ Coverage Diff @@
## master #1119 +/- ##
==========================================
+ Coverage 98.48% 98.49% +0.01%
==========================================
Files 22 22
Lines 4747 4790 +43
==========================================
+ Hits 4675 4718 +43
Misses 72 72
Continue to review full report at Codecov.
|
| python-version: ${{ matrix.python-version }} | ||
| - name: Install python prerequisites | ||
| run: pip install -U --user pip setuptools setuptools-scm flake8 | ||
| run: pip install -U --user pip setuptools setuptools-scm nox |
There was a problem hiding this comment.
Don't you still need to install flake8?
There was a problem hiding this comment.
No, nox manages virtual environments and the nox script defines what needs to be installed. This allows us to have a singular definition of what is needed to run a test instead of scattered definitions across multiple scripts.
| python-version: ${{ matrix.python-version }} | ||
| - name: Install python prerequisites | ||
| run: pip install -U --user pip setuptools setuptools-scm mypy | ||
| run: pip install -U --user pip setuptools setuptools-scm nox |
There was a problem hiding this comment.
You don't need to still install mypy?
| @@ -1,3 +1,7 @@ | |||
| ## 2.1.0 (TBD, 2021) | |||
| * Enhancements | |||
| * Converted persistent history files from pickle to compressed JSON | |||
There was a problem hiding this comment.
What will happen if someone with an old pickle-based history file upgrades to 2.1.0?
There was a problem hiding this comment.
It will print an error and start history from scratch. Since 2.0.0 just came out a few days ago, I doubt this will affect too many people.
There was a problem hiding this comment.
I updated the error message to include:
The history file will be recreated when this application exits.
Fixes #1113
Fixes #1118
Converted persistent history files from pickle to compressed JSON