Delete the cmd2_ext_test.py plugin code from the cmd2 repo
#1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Copy the ExternalTestMixin class implementation to the `tests_isolated_test_commandset/conftest.py` file - Remove info on the External Test Plugin from the documentation - Add info on the cmd2 Plugin Template to the documentation - Remove loading of `cmd2-ext-test` source code from the pyproject.toml - Removed ext-test stuff from tasks.py for invoke usage There is likely a lot more cleanup that can and should be done. This is just a first attempt to get our GitHub Actions CI/CD working without this plugin's circular dependency.
|
🤖 Hi @tleonhardt, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1518 +/- ##
==========================================
+ Coverage 98.79% 98.90% +0.11%
==========================================
Files 23 21 -2
Lines 4961 4933 -28
==========================================
- Hits 4901 4879 -22
+ Misses 60 54 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review Summary
This pull request effectively removes the cmd2-ext-test plugin and integrates its functionality directly into the test suite. The changes are well-focused on resolving the circular dependency issue.
🔍 General Feedback
- The removal of the plugin and its references from the documentation and build system is thorough.
- I've identified one critical issue in
tests_isolated/test_commandset/conftest.pywhere theExternalTestMixinis missing its base class. This needs to be fixed to ensure the mixin works as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the
cmd2-ext-testplugin code from the cmd2 repo and remove all reference to it. The last release of this plugin was over 4 years ago and as such it has been effectively abandoned. The testing ofcmd2proper should never have had a circular dependency on this plugin.Also:
ExternalTestMixinclass implementation to thetests_isolated_test_commandset/conftest.pyfilecmd2-ext-testsource code from thepyproject.tomltasks.pyforinvokeusageThere is likely a lot more cleanup that can and should be done. This is just a first attempt to get our GitHub Actions CI/CD working without this plugin's circular dependency.
Closes #1517