Skip to content

Conversation

kmvanbrunt
Copy link
Member

Added ability to alter the buffer size used when piping command output to a shell command.
Added BROKEN_PIPE_ERROR to handle compatibility issues with Python 2 and 3 when dealing with a broken pipe.

kmvanbrunt and others added 3 commits August 10, 2017 00:22
… larger when piping to shell commands.

Fixed error caused by BrokenPipeError not existing in Python 2.
@kmvanbrunt kmvanbrunt requested a review from tleonhardt as a code owner August 10, 2017 15:46
@codecov
Copy link

codecov bot commented Aug 10, 2017

Codecov Report

Merging #203 into master will increase coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage    96.8%   96.81%   +0.01%     
==========================================
  Files           1        1              
  Lines        1158     1162       +4     
==========================================
+ Hits         1121     1125       +4     
  Misses         37       37
Impacted Files Coverage Δ
cmd2.py 96.81% <75%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 256e069...c5f9ca9. Read the comment docs.

Copy link
Member

@tleonhardt tleonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the PR!

@tleonhardt tleonhardt merged commit b319900 into master Aug 10, 2017
@tleonhardt tleonhardt deleted the buffer_size branch August 10, 2017 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants