Skip to content

Conversation

tleonhardt
Copy link
Member

Added an extra check to cmd2.Cmd.ppaged() to make sure we are running in a real terminal before attempting to use a pager.

This is mostly to allow automated testing of cmd2 applications using things like Jenkins + pexpect.

…a real terminal before attempting to use a pager
@tleonhardt tleonhardt added this to the 0.8.2 milestone Mar 20, 2018
@tleonhardt tleonhardt self-assigned this Mar 20, 2018
@tleonhardt tleonhardt requested a review from kmvanbrunt March 20, 2018 20:30
@codecov
Copy link

codecov bot commented Mar 20, 2018

Codecov Report

Merging #324 into master will decrease coverage by 0.22%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   91.22%   90.99%   -0.23%     
==========================================
  Files           1        1              
  Lines        1629     1633       +4     
==========================================
  Hits         1486     1486              
- Misses        143      147       +4
Impacted Files Coverage Δ
cmd2.py 90.99% <0%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 328b408...0faf895. Read the comment docs.

@tleonhardt tleonhardt merged commit 3800261 into master Mar 20, 2018
@tleonhardt tleonhardt deleted the ppaged_terminal branch March 20, 2018 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant