Fixed issue where calling exit() or quit() from a pyscript would close the whole console #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the whole console
Codecov Report
@@ Coverage Diff @@
## master #623 +/- ##
==========================================
- Coverage 93.31% 93.21% -0.11%
==========================================
Files 11 11
Lines 3188 3196 +8
==========================================
+ Hits 2975 2979 +4
- Misses 213 217 +4
Continue to review full report at Codecov.
|
tleonhardt
requested changes
Feb 6, 2019
|
|
||
| except Exception: |
There was a problem hiding this comment.
I think we need something like this to catch a KeyboardInterrupt exception (Ctrl-C) and let that gracefully exit the interactive Python session and drop us back to the console
There was a problem hiding this comment.
I allow the interactive Python session to handle their own exceptions. I did however add KeyboardInterrupt suppression to py and pyscript for when the interactive console isn't running.
…active console isn't running
tleonhardt
approved these changes
Feb 6, 2019
| @@ -3109,10 +3115,12 @@ def quit(): | |||
| else: | |||
| sys.modules['readline'] = saved_readline | |||
|
|
|||
| except Exception: | |||
| except KeyboardInterrupt: | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #620