Skip to content

Fixed issue where pointer to bytearray was being returned instead of copied bytes #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Fixed issue where pointer to bytearray was being returned instead of copied bytes #664

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f5339e
Fixed issue where pointer to bytearray was being returned instead of …
kmvanbrunt Apr 11, 2019
1f08873
Clearing bytearray instead of creating a new object
kmvanbrunt Apr 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd2/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ def getvalue(self) -> str:

def getbytes(self) -> bytes:
"""Get the internal contents as bytes"""
return self.buffer.byte_buf
return bytes(self.buffer.byte_buf)

def read(self) -> str:
"""Read from the internal contents as a str and then clear them out"""
Expand All @@ -341,7 +341,7 @@ def readbytes(self) -> bytes:

def clear(self) -> None:
"""Clear the internal contents"""
self.buffer.byte_buf = bytearray()
self.buffer.byte_buf.clear()

def isatty(self) -> bool:
"""StdSim only considered an interactive stream if `echo` is True and `inner_stream` is a tty."""
Expand Down