Skip to content

Conversation

kmvanbrunt
Copy link
Member

Closes #748
Added set_choices_function(), set_choices_method(), set_completer_function(), and set_completer_method() to support cases where this functionality needs to be added to an argparse action outside of the normal parser.add_argument() call.

@kmvanbrunt kmvanbrunt added this to the 0.9.16 milestone Aug 5, 2019
@kmvanbrunt kmvanbrunt requested a review from tleonhardt as a code owner August 5, 2019 21:35
@kmvanbrunt kmvanbrunt self-assigned this Aug 5, 2019
@codecov
Copy link

codecov bot commented Aug 5, 2019

Codecov Report

Merging #750 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   97.27%   97.29%   +0.01%     
==========================================
  Files          13       13              
  Lines        3419     3432      +13     
==========================================
+ Hits         3326     3339      +13     
  Misses         93       93
Impacted Files Coverage Δ
cmd2/argparse_custom.py 94.13% <100%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa8370...0ffe33d. Read the comment docs.

Copy link
Member

@tleonhardt tleonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@kmvanbrunt kmvanbrunt merged commit 0f9fcfc into master Aug 6, 2019
@kmvanbrunt kmvanbrunt deleted the support_custom_actions branch August 6, 2019 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

help with upgrading autocompletion to 0.9.15
2 participants