Verifying command names in __init__ #755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
==========================================
+ Coverage 97.3% 97.31% +<.01%
==========================================
Files 13 13
Lines 3454 3458 +4
==========================================
+ Hits 3361 3365 +4
Misses 93 93
Continue to review full report at Codecov.
|
tleonhardt
approved these changes
Aug 8, 2019
| shortcuts=shortcuts) | ||
|
|
||
| # Verify commands don't have invalid names (like starting with a shortcut) | ||
| for cur_cmd in self.get_all_commands(): |
There was a problem hiding this comment.
Yeah this is prudent and I can't think of a better way to validate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preventing things like commands that begin with a shortcut