Skip to content

Conversation

tleonhardt
Copy link
Member

@tleonhardt tleonhardt commented Sep 20, 2019

These PR contains Sphinx documentation improvements made within the past month by @kotfu. I would like to merge them into master prior to the next release (hence the PR).

This partially addresses #765, but more work for that still remains.

@tleonhardt tleonhardt added this to the 0.9.17 milestone Sep 20, 2019
@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #780 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #780   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files          13       13           
  Lines        3453     3453           
=======================================
  Hits         3361     3361           
  Misses         92       92

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1176c0c...b45fec9. Read the comment docs.


``cmd2`` passes ``arg`` to a ``do_`` method (or ``default``) as a Statement, a
subclass of string that includes many attributes of the parsed input:
Basic Commands
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kotfu You did a great job improving the documentation in this file. I really like how it flows.

@kotfu
Copy link
Member

kotfu commented Sep 21, 2019

Yup, let's merge this in. I'll start another branch to continue more documentation work.

@tleonhardt tleonhardt merged commit 27a0adb into master Sep 22, 2019
@tleonhardt tleonhardt deleted the doc_additions branch September 22, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants