Enabled line buffering when redirecting output to a file #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
=======================================
Coverage 97.23% 97.23%
=======================================
Files 14 14
Lines 3512 3512
=======================================
Hits 3415 3415
Misses 97 97
Continue to review full report at Codecov.
|
tleonhardt
previously approved these changes
Dec 6, 2019
cmd2/cmd2.py
Outdated
| mode = 'a' | ||
| else: | ||
| mode = 'w' | ||
| mode += 't' |
There was a problem hiding this comment.
I thought text mode is the default and thus that this is redundant but explicit?
There was a problem hiding this comment.
You are correct, it is redundant. I removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes tailing a file that's being outputted to more responsive