Skip to content

Conversation

tleonhardt
Copy link
Member

Moved custom cmd2 exceptions to a separate file and removed them from public API.

Closes #889

@tleonhardt tleonhardt added this to the 0.10.1 milestone Feb 19, 2020
@tleonhardt tleonhardt self-assigned this Feb 19, 2020
@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #893 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
- Coverage   97.46%   97.43%   -0.04%     
==========================================
  Files          14       15       +1     
  Lines        3674     3669       -5     
==========================================
- Hits         3581     3575       -6     
- Misses         93       94       +1     
Impacted Files Coverage Δ
cmd2/rl_utils.py 100.00% <0.00%> (ø) ⬆️
cmd2/clipboard.py 100.00% <0.00%> (ø) ⬆️
cmd2/cmd2.py 96.66% <0.00%> (-0.01%) ⬇️
cmd2/utils.py 97.89% <0.00%> (-0.27%) ⬇️
cmd2/plugin.py 100.00% <0.00%> (ø) ⬆️
cmd2/history.py 100.00% <0.00%> (ø) ⬆️
cmd2/parsing.py 100.00% <0.00%> (ø) ⬆️
cmd2/exceptions.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 970c5fc...eecb0ac. Read the comment docs.

kmvanbrunt
kmvanbrunt previously approved these changes Feb 19, 2020
@kmvanbrunt kmvanbrunt merged commit 566f38c into master Feb 19, 2020
@kmvanbrunt kmvanbrunt deleted the EmptyStatement_visibility branch February 19, 2020 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-evaluate visibility of EmptyStatement exception
2 participants