Skip to content

Release prep #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Release prep #894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23a0de4
Renamed _autocomplete_default to _complete_argparse_command
kmvanbrunt Feb 19, 2020
5ff2c53
Updated change log for release
kmvanbrunt Feb 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## 0.10.1 (February TBD, 2020)
## 0.10.1 (February 19, 2020)
* Bug Fixes
* Corrected issue where the actual new value was not always being printed in do_set. This occurred in cases where
the typed value differed from what the setter had converted it to.
Expand All @@ -20,6 +20,10 @@
* Removed undocumented `py run` command since it was replaced by `run_pyscript` a while ago
* Renamed `AutoCompleter` to `ArgparseCompleter` for clarity
* Custom `EmptyStatement` exception is no longer part of the documented public API
* Notes
* This is a beta release leading up to the 1.0.0 release
* We intend no more breaking changes prior to 1.0.0
* Just bug fixes, documentation updates, and enhancements

## 0.10.0 (February 7, 2020)
* Enhancements
Expand Down
8 changes: 4 additions & 4 deletions cmd2/cmd2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1254,7 +1254,7 @@ def _completion_for_command(self, text: str, line: str, begidx: int,

if func is not None and argparser is not None:
import functools
compfunc = functools.partial(self._autocomplete_default,
compfunc = functools.partial(self._complete_argparse_command,
argparser=argparser,
preserve_quotes=getattr(func, constants.CMD_ATTR_PRESERVE_QUOTES))
else:
Expand Down Expand Up @@ -1423,9 +1423,9 @@ def complete(self, text: str, state: int) -> Optional[str]:
rl_force_redisplay()
return None

def _autocomplete_default(self, text: str, line: str, begidx: int, endidx: int, *,
argparser: argparse.ArgumentParser, preserve_quotes: bool) -> List[str]:
"""Default completion function for argparse commands"""
def _complete_argparse_command(self, text: str, line: str, begidx: int, endidx: int, *,
argparser: argparse.ArgumentParser, preserve_quotes: bool) -> List[str]:
"""Completion function for argparse commands"""
from .argparse_completer import ArgparseCompleter
completer = ArgparseCompleter(argparser, self)
tokens, raw_tokens = self.tokens_for_completion(line, begidx, endidx)
Expand Down