Skip to content

Conversation

tleonhardt
Copy link
Member

This closes #946

Also:

  • Ran isort which made a small whitespace change in one other file

@tleonhardt tleonhardt added the bug label Jul 14, 2020
@tleonhardt tleonhardt added this to the 1.2.0 milestone Jul 14, 2020
@tleonhardt tleonhardt requested a review from kmvanbrunt July 14, 2020 00:27
@tleonhardt tleonhardt requested a review from kotfu as a code owner July 14, 2020 00:27
@tleonhardt tleonhardt self-assigned this Jul 14, 2020
@codecov
Copy link

codecov bot commented Jul 14, 2020

Codecov Report

Merging #955 into master will decrease coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
- Coverage   97.72%   97.65%   -0.07%     
==========================================
  Files          19       19              
  Lines        4183     4188       +5     
==========================================
+ Hits         4088     4090       +2     
- Misses         95       98       +3     
Impacted Files Coverage Δ
cmd2/table_creator.py 99.27% <50.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27a8414...95d6a25. Read the comment docs.

@kmvanbrunt kmvanbrunt self-requested a review July 14, 2020 00:54
@tleonhardt tleonhardt merged commit 104f9af into master Jul 14, 2020
@tleonhardt tleonhardt deleted the typing_deque branch July 14, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

usage of typing.Deque breaks compatibility
2 participants