Fixed AttributeError when loading CommandSet #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tleonhardt
previously approved these changes
Aug 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #980 +/- ##
=======================================
Coverage 97.82% 97.83%
=======================================
Files 22 22
Lines 4516 4522 +6
=======================================
+ Hits 4418 4424 +6
Misses 98 98
Continue to review full report at Codecov.
|
…ator is loaded during cmd2.Cmd.__init__().
kmvanbrunt
force-pushed
the
move_module_loading
branch
from
fd31083 to
30d010f
Compare
tleonhardt
previously approved these changes
Aug 20, 2020
anselor
force-pushed
the
move_module_loading
branch
4 times, most recently
from
64555b2 to
6b36d64
Compare
tleonhardt
previously approved these changes
Aug 20, 2020
|
|
||
| subcommand_valid, errmsg = self.statement_parser.is_valid_command(subcommand_name, is_subcommand=True) | ||
| if not subcommand_valid: | ||
| raise CommandSetRegistrationError('Subcommand {} is not valid: {}'.format(str(subcommand_name), errmsg)) |
There was a problem hiding this comment.
Thanks for adding a better error message
| @@ -0,0 +1,46 @@ | |||
| Testing | |||
There was a problem hiding this comment.
Thanks for adding this section on testing!
Added unit test to verify command name validation updates.
anselor
force-pushed
the
move_module_loading
branch
from
e5a23a4 to
27b1093
Compare
tleonhardt
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following error occured when
CommandSetthat usesas_subcommand_todecorator was loaded duringcmd2.Cmd.__init__().The fix was to move the loading code after all
Cmdattributes have been created.This also added in improved exception message and documentation for testing errors related to poor mocking practices when unit testing.
Closes #981