Fixed RecursionError when printing an argparse.Namespace #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmvanbrunt
force-pushed
the
recursion_error
branch
from
fa886eb to
ac1639e
Compare
Codecov Report
@@ Coverage Diff @@
## master #984 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 22 22
Lines 4522 4523 +1
=======================================
+ Hits 4424 4425 +1
Misses 98 98
Continue to review full report at Codecov.
|
…stom attribute cmd2 was adding Added get_statement() function to argparse.Namespace which returns __statement__ attribute
kmvanbrunt
force-pushed
the
recursion_error
branch
from
ac1639e to
9b5a988
Compare
tleonhardt
approved these changes
Aug 25, 2020
anselor
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #983
RecursionErrorwhen printing anargparse.Namespacecaused by custom attribute cmd2 was addingget_statement()function toargparse.Namespacewhich returns__statement__attribute