Removed need to set add_help to False for @as_subcommand_to decorator #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tleonhardt
previously approved these changes
Aug 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #988 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 22 22
Lines 4533 4533
=======================================
Hits 4435 4435
Misses 98 98
Continue to review full report at Codecov.
|
|
Looks good |
anselor
previously approved these changes
Aug 28, 2020
…id not display help when called with -h/--help. 'add_help=False' no longer has to be passed to parsers used in @as_subcommand_to decorator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@as_subcommand_todecorator did not display help when called with-h/--help.add_help=Falseno longer has to be passed to parsers used in@as_subcommand_todecorator.Only pass this if your subcommand should not have the
-h/--helphelp option (as stated in argparse documentation).