Added callbacks to CommandSet #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #990 +/- ##
=======================================
Coverage 97.83% 97.84%
=======================================
Files 22 22
Lines 4533 4540 +7
=======================================
+ Hits 4435 4442 +7
Misses 98 98
Continue to review full report at Codecov.
|
tleonhardt
previously approved these changes
Sep 2, 2020
kmvanbrunt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommandSet.on_unregister()is now called as first step in unregistering aCommandSetand not the last.CommandSet.on_unregistered()is now the last step.CommandSet.on_registered(). This is called bycmd2.Cmdafter aCommandSetis registered and all its commands have been added to the CLI.CommandSet.on_unregistered(). This is called bycmd2.Cmdafter aCommandSetis unregistered and all its commands have been removed from the CLI.