This repository was archived by the owner on Mar 14, 2021. It is now read-only.
Team 20 #6
Open
Team 20 #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Pipfile dependencies
Exclude virtualenv from Flake8 linting. Again.
[UPDATE] Ignored a silly rule from flake8.
Adding W503 and E226 to flake8 ignore list.
…wing syntax errors from ast.literal_eval
gdude2002
suggested changes
Mar 25, 2018
|
It is in work, my partner is (or should be) doing research while i am extending our db |
|
Here you go @gdude2002 |
|
wooooops missclicked |
jb3
reviewed
Mar 25, 2018
|
|
||
| # Any additional commands can be placed here. Be creative, but keep it to a reasonable amount! | ||
| @command() | ||
| async def hiss(self, ctx: Context): |
There was a problem hiding this comment.
If someone executes this twice within a short period of time will there be an error, or will the sound play twice at the same time?
There was a problem hiding this comment.
You may want to check the clients voice status before making it play more.
There was a problem hiding this comment.
discordpy appears to handle this fine.(just tested it)
lemonsaurus
reviewed
Mar 25, 2018
bot/cogs/snakes.py
Outdated
| return ("python", self.python_info, self.python_image) | ||
| else: | ||
| for key in self.db.keys(): | ||
| if key.lower() == name.lower(): |
There was a problem hiding this comment.
but you already lowered the name..?
bot/cogs/snakes.py
Outdated
| if key.lower() == name.lower(): | ||
| return (key, self.db[key][0], self.db[key][1]) | ||
| else: | ||
| key = random.choice(list(self.db.keys())) |
There was a problem hiding this comment.
You don't need the .keys(). casting a dict to list will already return the keys.
key = random.choice(list(self.db))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.