Add Infraction Tests to the testing suite #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also introduces minor enhancements in the overall consistency of tests, and conftest files.
Pull Request Test Coverage Report for Build 1638766705
💛 - Coveralls |
ChrisLovering
approved these changes
Dec 30, 2021
There was a problem hiding this comment.
Looks good to me, tests all pass locally, nice job!
For the readme, could you add some info on how to run these tests under docker?
IE
- create a
.envfile withDATABASE_URL=postgresql+asyncpg://codejam_management:codejam_management@localhost:7777/codejam_managementin it - run
docker-compose up - run
pytestlocally
|
Yeah, sure thing! |
ToxicKidz
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds Infractions tests to the testing suite (Just like the title says), and it also introduces minor consistency enhancements in the testing suite.