Skip to content
This repository was archived by the owner on Aug 14, 2023. It is now read-only.

Add git crypt for secrets #156

Merged
merged 19 commits into from
Jul 21, 2023
Merged

Add git crypt for secrets #156

merged 19 commits into from
Jul 21, 2023

Conversation

ChrisLovering
Copy link
Member

@ChrisLovering ChrisLovering commented Jul 18, 2023 •
edited
Loading

No description provided.

@ChrisLovering ChrisLovering force-pushed the add-git-crypt-for-secrets branch 7 times, most recently from 2b0ad1b to 9b64bb4 Compare July 18, 2023 20:23
@ChrisLovering ChrisLovering marked this pull request as ready for review July 18, 2023 20:25
@ChrisLovering ChrisLovering requested a review from a team as a code owner July 18, 2023 20:25
@jchristgit jchristgit self-assigned this Jul 18, 2023
@jchristgit jchristgit linked an issue Jul 18, 2023 that may be closed by this pull request
Discussion: git-crypt for secrets #104
Closed
@jchristgit jchristgit mentioned this pull request Jul 18, 2023
Closed
@ChrisLovering ChrisLovering force-pushed the add-git-crypt-for-secrets branch 2 times, most recently from 2fba33a to a00e330 Compare July 18, 2023 22:56
@ChrisLovering ChrisLovering marked this pull request as draft July 19, 2023 10:27
@ChrisLovering ChrisLovering marked this pull request as ready for review July 19, 2023 10:27
@ChrisLovering
Add 5 git-crypt collaborators
3262607 
New collaborators:

	5872D5E4 Chris Lovering <chris.lovering.95@gmail.com>
	2F2E17AF Johannes Christ <jc@jchri.st>
	E4D4D9C9 Joe Banks <joe@jb3.dev>
	8BB0BC18 Hassan Abouelela <hassan@hassanamr.com>
	0C155B71 Xithrius <xithrius@fastmail.com>
@ChrisLovering
git-crypt all secrets.yaml files
adfae3c
@ChrisLovering
Remove logcord deployment
fbd888b
@ChrisLovering
Move exporters into their own files
8b63063
@ChrisLovering
Move all secrets into git-crypt secret files
d4b70db
@ChrisLovering
Scale grafana-image-renderer back to 0 replicas
f0c4aea
@ChrisLovering
Use the latest release of policy bot
ee6e7d1
@ChrisLovering
Update postgres.conf with new settings
a5ab6d3
@ChrisLovering
Add query volume path to postgres exporter role
7be4294 
This was already in produciton, it just wasn't committed
@ChrisLovering
Add metricity secrets to repo
4f07687
@ChrisLovering
Don't try to lint secrets.yaml files
e926147 
They are binary files thanks to git-crypt, so they can't be read by CI
@ChrisLovering
Move redis pass to secret to allow configmap to be committed
21804cc
@ChrisLovering
Document secrets within each app's README
6c9415a
@ChrisLovering
Remove deprecated secret from modmail-bot secret
2757cd9
HassanAbouelela
HassanAbouelela reviewed Jul 19, 2023
View reviewed changes
README.md Outdated
--from-literal=MY_FAVORITE_THING=lemons \
--from-literal=SUPER_LAME_DOG=snoopy
```
To work with our secrets, you must have your GPG key added by a member of the devops team. Once that is done, you have use git-crypt as documented.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the last sentence here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/have/can https://github.com/python-discord/kubernetes/compare/8143937f27b6b131dd278d51b797473d6e92a7d0..e6f3cd69d6852c9beb148f49bb99b23dc27c0427

@ChrisLovering ChrisLovering force-pushed the add-git-crypt-for-secrets branch from 8143937 to e6f3cd6 Compare July 19, 2023 14:03
@jchristgit jchristgit added priority: critical hacktoberfest-accepted good first issue Good for newcomers type: enhancement Changes or improvements to existing features priority: high type: feature A request for or implementation of a new feature area: documentation area: deployments and removed good first issue Good for newcomers priority: critical type: enhancement Changes or improvements to existing features priority: high labels Jul 19, 2023
jchristgit
jchristgit reviewed Jul 19, 2023
View reviewed changes
@jchristgit
Copy link
Member

Ping me when this is ready for review

@ChrisLovering
Copy link
Member Author

@jchristgit

jchristgit
jchristgit approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MACHINE!

@jchristgit
Copy link
Member

Is this ready for merge as well? Feel free

@ChrisLovering ChrisLovering merged commit 1515ede into main Jul 21, 2023
@ChrisLovering ChrisLovering deleted the add-git-crypt-for-secrets branch July 21, 2023 19:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@HassanAbouelela HassanAbouelela HassanAbouelela approved these changes

@jchristgit jchristgit jchristgit approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jchristgit jchristgit

Labels
area: deployments area: documentation area: monitoring priority: critical type: feature A request for or implementation of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discussion: git-crypt for secrets
3 participants
@ChrisLovering @jchristgit @HassanAbouelela