Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Discord.py masterclass resource #1421

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Add Discord.py masterclass resource #1421

merged 1 commit into from
Aug 22, 2024

Conversation

jb3
Copy link
Member

@jb3 jb3 commented Aug 22, 2024

Adds a resource suggested in community meta.

I've scoped it out and believe that:

  • It teaches good coding practices for the most part
  • It makes good use of type annotations
  • It covers a wide range of functionality
  • It's content is appropriate and keeps in line with our community expectations

@netlify Netlify
Copy link

netlify bot commented Aug 22, 2024 •
edited
Loading

✅ Deploy Preview for pydis-static ready!

Name Link
🔨 Latest commit d0c6587
🔍 Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/66c7bdbbfdf9980008e93314
😎 Deploy Preview https://deploy-preview-1421--pydis-static.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling d0c6587 on jb3/resources/discord.py-masterclass
into 325fda3 on main.

vivekashok1221
vivekashok1221 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@vivekashok1221 vivekashok1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shtlrs
shtlrs approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@shtlrs shtlrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know what I have to say, G.O.A.T

@KeithTheEE KeithTheEE merged commit 50bedf5 into main Aug 22, 2024
12 checks passed
@KeithTheEE KeithTheEE deleted the jb3/resources/discord.py-masterclass branch August 22, 2024 23:23
@jb3
Copy link
Member Author

jb3 commented Aug 22, 2024

You know what I have to say, G.O.A.T

MY HERO!!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekashok1221 vivekashok1221 vivekashok1221 approved these changes

@shtlrs shtlrs shtlrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jb3 @coveralls @vivekashok1221 @shtlrs @KeithTheEE