Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include DestroyModelMixin to infractions view for DELETE method #432

Merged
merged 3 commits into from
Dec 14, 2020
Merged

Include DestroyModelMixin to infractions view for DELETE method #432

merged 3 commits into from
Dec 14, 2020

Conversation

ks129
Copy link
Member

@ks129 ks129 commented Dec 5, 2020

Closes #430

Added this mixin and documented this in doctoring.

@ks129
Include DestroyModelMixin to infractions view for DELETE method
9efd0cb 
Added this mixin and documented this in doctoring.
@ks129 ks129 added the area: API Related to or causes API changes label Dec 5, 2020
@ks129 ks129 requested a review from MarkKoz as a code owner December 5, 2020 17:20
@ghost ghost added the needs 2 approvals label Dec 5, 2020
@coveralls
Copy link

coveralls commented Dec 5, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 13ffd12 on ks123/infractions/delete-method into a2992d9 on master.

MarkKoz
MarkKoz requested changes Dec 6, 2020
View reviewed changes
Copy link
Member

@MarkKoz MarkKoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some tests written.

@ghost ghost added s: waiting for author Waiting for author to address a review or respond to a comment and removed needs 2 approvals labels Dec 6, 2020
@MarkKoz MarkKoz added priority: 2 - normal Normal Priority type: feature New feature or request labels Dec 6, 2020
@ghost ghost added needs 2 approvals and removed s: waiting for author Waiting for author to address a review or respond to a comment labels Dec 9, 2020
@ks129 ks129 requested a review from MarkKoz December 9, 2020 06:18
Den4200
Den4200 approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@Den4200 Den4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ghost ghost removed the needs 1 approval label Dec 14, 2020
@Den4200 Den4200 merged commit a4ba622 into master Dec 14, 2020
@Den4200 Den4200 deleted the ks123/infractions/delete-method branch December 14, 2020 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Den4200 Den4200 Den4200 approved these changes

@MarkKoz MarkKoz MarkKoz approved these changes

Assignees
No one assigned
Labels
area: API Related to or causes API changes priority: 2 - normal Normal Priority type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support deleting infractions
4 participants
@ks129 @coveralls @MarkKoz @Den4200