Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update guides to use poetry instead of pipenv #511

Merged
merged 2 commits into from
May 27, 2021
Merged

Update guides to use poetry instead of pipenv #511

merged 2 commits into from
May 27, 2021

Conversation

ToxicKidz
Copy link
Contributor

We've recently changed site, bot and sir-lancebot to use poetry instead of pipenv. This PR updates the contributing guides that still mention pipenv.

@coveralls
Copy link

coveralls commented May 22, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 3ff5d03 on update/docs-pipenv-to-poetry into 7d6de90 on main.

kosayoda
kosayoda approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@kosayoda kosayoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doublevcodes
doublevcodes approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@doublevcodes doublevcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Akarys42
Akarys42 approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@Akarys42 Akarys42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Akarys42 Akarys42 enabled auto-merge May 27, 2021 18:11
@Akarys42 Akarys42 merged commit c5fda5d into main May 27, 2021
@Akarys42 Akarys42 deleted the update/docs-pipenv-to-poetry branch May 27, 2021 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doublevcodes doublevcodes doublevcodes approved these changes

@Akarys42 Akarys42 Akarys42 approved these changes

@kosayoda kosayoda kosayoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ToxicKidz @coveralls @kosayoda @Akarys42 @doublevcodes