Skip to content

Conversation

ChrisLovering
Copy link
Member

@ChrisLovering ChrisLovering commented Aug 24, 2025

Tests all just passed locally. The nsjail bump does take us through a major version update, but doesn't seem breaking for us.

@coveralls
Copy link

coveralls commented Aug 24, 2025

Coverage Status

coverage: 88.265%. remained the same
when pulling 6d23abb on update-all-the-versions
into c23e8cd on main.

Copy link
Member

@jb3 jb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chris, this is some of your greatest work yet. Keep up the good work! :shipit:

@jb3 jb3 force-pushed the update-all-the-versions branch from 759e7a3 to 8ef2a6f Compare August 30, 2025 19:53
@jb3 jb3 enabled auto-merge August 30, 2025 19:54
@MarkKoz
Copy link
Member

MarkKoz commented Aug 30, 2025

When we update nsjail we should regenerate the protobuf code for its config. I believe our README explains this process.

@ChrisLovering
Copy link
Member Author

When we update nsjail we should regenerate the protobuf code for its config. I believe our README explains this process.

Ah cool, didn't know about this, I'm assuming it's ./scripts/protoc.py 3.4 can look tomorrow unless joe gets it first

@jb3 jb3 force-pushed the update-all-the-versions branch from 8ef2a6f to af5bb1b Compare August 30, 2025 20:52
@jb3 jb3 force-pushed the update-all-the-versions branch from af5bb1b to 6d23abb Compare August 30, 2025 20:58
@jb3 jb3 disabled auto-merge August 30, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants