Skip to content
This repository was archived by the owner on Aug 26, 2024. It is now read-only.

Conversation

sounak98
Copy link
Contributor

Description

This adds a new runcron process which will deactivate a user on a certain date and time. Helps in deactivating users after the current GSoC period.

Fixes #66

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Had added the deactivation date for a UserProfile in the admin panel and the user got deactivated when the runcron process_items was run after the scheduled date and time

Checklist:

  • My code follows the style guidelines of this project
  • I have not added a commit to any .db files as part of my pull request
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@botanicvelious
Copy link
Collaborator

  • This branch has conflicts that must be resolved
  • I don't see any code for the admin page to let you set the date to deactivate the user.

@sounak98 sounak98 force-pushed the deactivation-user branch from aaa0224 to 178ab89 Compare March 20, 2019 07:09
@sounak98
Copy link
Contributor Author

178ab89#diff-663dbff8f9c23aa31f98584578a8959fR7

@botanicvelious this is the part which incorporates the date field in the UserProfile form in the admin panel. Also the merge conflicts have been resolved.

@botanicvelious
Copy link
Collaborator

So it looks like you applied this to the userprofile objects which made it so that the admin page now has User profile: UserProfile object (1) User profile: UserProfile object (2) etc. The deactivate should be done on the user, not per object.

@sounak98
Copy link
Contributor Author

Oh okay, I'll change it to the user rather than on the UserProfile.

@sounak98 sounak98 force-pushed the deactivation-user branch from 5a5e061 to 6b9bfe3 Compare March 21, 2019 12:48
@sounak98 sounak98 force-pushed the deactivation-user branch from 6b9bfe3 to 9a40b4c Compare March 21, 2019 12:49
@sounak98 sounak98 force-pushed the deactivation-user branch from 7a94f78 to 47aa5b3 Compare March 21, 2019 13:05
@botanicvelious botanicvelious merged commit eb52e98 into python-gsoc:master Mar 22, 2019
@sounak98 sounak98 deleted the deactivation-user branch March 25, 2019 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants