Skip to content
This repository was archived by the owner on Aug 26, 2024. It is now read-only.

Conversation

sounak98
Copy link
Contributor

@sounak98 sounak98 commented Mar 25, 2019

  • Fixes minor typo in README.md
  • Adds CLIPBOARD_BREAK = 'Clipboard Break' to cms_toolbars.py

@ghost
Copy link

ghost commented Mar 25, 2019

Now I know why I couldnt login that account. 👍

@sounak98 sounak98 changed the title Fix typo Fix typo and minor bug Mar 25, 2019
@botanicvelious
Copy link
Collaborator

botanicvelious commented Mar 30, 2019

Isn't these variables being set still so there values important, why are they being removed?

# # Identifiers for search
ADMIN_MENU_IDENTIFIER = 'admin-menu'
ADMINISTRATION_BREAK = 'Administration Break'
USER_SETTINGS_BREAK = 'User Settings Break'
TOOLBAR_DISABLE_BREAK = 'Toolbar disable Break'
SHORTCUTS_BREAK = 'Shortcuts Break'

@sounak98
Copy link
Contributor Author

@botanicvelious I was just re-declaring the variables. These variables are already declared in djangocms. That is why I am just importing them from cms.cms_toolbars.

@botanicvelious botanicvelious merged commit 6f82732 into python-gsoc:master Mar 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants