Skip to content

Unpin Pylint #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 15, 2021
Merged

Unpin Pylint #94

merged 4 commits into from
Oct 15, 2021

Conversation

bnavigator
Copy link
Contributor

@bnavigator bnavigator commented Oct 3, 2021 •
edited
Loading

  • Addresses all warnings and suggestions coming up during static analysis of the python-lsp-server code
  • Fixes the failing unittests in test_pylint.py with the file itself as input src
  • Reverts Require Pylint less than 2.10 #78

@bnavigator bnavigator marked this pull request as ready for review October 3, 2021 21:05
@ccordoba12 ccordoba12 changed the title unpin pylint Unpin Pylint Oct 9, 2021
@ccordoba12 ccordoba12 added this to the v1.3.0 milestone Oct 9, 2021
@ccordoba12 ccordoba12 mentioned this pull request Oct 9, 2021
Merged
ccordoba12
ccordoba12 approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @bnavigator!

@ccordoba12 ccordoba12 merged commit e8cf8e5 into python-lsp:develop Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bnavigator @ccordoba12