Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could we add Google Cloud KMS encryption #228

Closed
jeffny2015 opened this issue Mar 19, 2021 · 6 comments · Fixed by python-microservices/python-microservices.github.io#9
Closed

Comments

@jeffny2015
Copy link

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

i see documentation say it supports but i dont see it implemented

@alexppg
Copy link
Member

alexppg commented Mar 19, 2021

Where do you see it? In the docs it only talks about AWS's KMS, as far as I can see: https://python-microservices.github.io/encrypt_decryt_configuration/#2-encrypt-with-kms

@jeffny2015
Copy link
Author

image

@jeffny2015
Copy link
Author

jeffny2015 commented Mar 19, 2021

You can move this file to a Kubernetes secret, use Vault or encrypt the configuration with AWS KMS or Google KMS. We strongly recommend these way of encrypting/decrypting your configuration, but if you don't want a vendor locking option or you don't have the resources to use these methods, we provide a way to encrypt and decrypt your variables.

@jeffny2015
Copy link
Author

jeffny2015 commented Mar 19, 2021

i mean, could you add it ?

@avara1986
Copy link
Member

We add this paragraph as recommendations and best practices to store configuration. In the nexts blocks describe the implementations that exists in PyMS. On the other hand, it could be confusing. We update this section, thanks @jeffny2015 for your contribution :)

@alexppg
Copy link
Member

alexppg commented Mar 21, 2021

My bad, I didn't see it.

avara1986 added a commit to python-microservices/python-microservices.github.io that referenced this issue Mar 28, 2021
avara1986 added a commit to python-microservices/python-microservices.github.io that referenced this issue Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants