Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added AWS kms support #105

Merged
merged 18 commits into from
Mar 30, 2020
Merged

Added AWS kms support #105

merged 18 commits into from
Mar 30, 2020

Conversation

avara1986
Copy link
Member

@avara1986 avara1986 commented Mar 27, 2020 •
edited
Loading

Fix Support encrypting secrets with kms, issue #70

@coveralls
Copy link

coveralls commented Mar 27, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 701

  • 226 of 227 (99.56%) changed or added relevant lines in 19 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 99.225%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyms/crypt/driver.py 30 31 96.77%
Totals Coverage Status
Change from base Build 679: 0.01%
Covered Lines: 1537
Relevant Lines: 1549
💛 - Coveralls

@avara1986 avara1986 added the feature New feature in progres label Mar 29, 2020
@avara1986 avara1986 linked an issue Mar 29, 2020 that may be closed by this pull request
Support encrypting secrets with kms #70
Closed
@avara1986 avara1986 merged commit 54933a0 into master Mar 30, 2020
@avara1986 avara1986 deleted the feature/add_aws_kms_support branch March 30, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexppg alexppg alexppg approved these changes

@miguelgrubin miguelgrubin Awaiting requested review from miguelgrubin

Assignees
No one assigned
Labels
feature New feature in progres
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support encrypting secrets with kms
3 participants
@avara1986 @coveralls @alexppg