Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config reload endpoint #174

Merged
merged 6 commits into from
Oct 4, 2020
Merged

Config reload endpoint #174

merged 6 commits into from
Oct 4, 2020

Conversation

lcd1232
Copy link
Contributor

@lcd1232 lcd1232 commented Oct 1, 2020

Fixes #71

Changes proposed in this PR:

  • Config reload endpoint

@coveralls
Copy link

coveralls commented Oct 1, 2020 •
edited

Pull Request Test Coverage Report for Build 932

  • 27 of 27 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 99.156%
Totals Coverage Status
Change from base Build 927: 0.01%
Covered Lines: 1644
Relevant Lines: 1658
💛 - Coveralls

@lcd1232
Copy link
Contributor Author

lcd1232 commented Oct 1, 2020

@avara1986 could you say what to do with linters?

avara1986
avara1986 requested changes Oct 2, 2020
View reviewed changes
pyms/flask/configreload/configreload.py Outdated Show resolved Hide resolved
@avara1986 avara1986 merged commit 810bb86 into python-microservices:master Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexppg alexppg alexppg left review comments

@avara1986 avara1986 avara1986 approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have an config reloader endpoint
4 participants
@lcd1232 @coveralls @avara1986 @alexppg